| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Event Triggers reduced, v1 |
| Date: | 2012-06-28 14:07:27 |
| Message-ID: | CA+TgmobjtY-57pZhnmX9zODidyb1qpzhkyD-UqL0R+HwSTgGmg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 28, 2012 at 9:46 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> [ review ]
Also:
../../../src/include/catalog/pg_event_trigger.h:34: error: expected
specifier-qualifier-list before ‘int2’
This needs to be changed to int16 as a result of commit
b8b2e3b2deeaab19715af063fc009b7c230b2336.
alter.c:73: warning: implicit declaration of function ‘RenameEventTrigger’
That file needs to include commands/event_trigger.h.
Please spell out DO_EVTTRIGGER as DO_EVENT_TRIGGER.
Another random warning:
plpy_main.c:195: warning: ‘retval’ may be used uninitialized in this function
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-06-28 14:11:31 | Re: Posix Shared Mem patch |
| Previous Message | Jon Nelson | 2012-06-28 14:06:08 | Re: Posix Shared Mem patch |