Fixed outfuncs

From: jwieck(at)debis(dot)com (Jan Wieck)
To: pgsql-hackers(at)postgreSQL(dot)org (PostgreSQL HACKERS)
Subject: Fixed outfuncs
Date: 1998-12-18 15:07:43
Message-ID: m0zr1VI-000EBPC@orion.SAPserv.Hamburg.dsh.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

just committed some fixes to get back the old "<>" for NULL
strings on nodeToString().

Marc's recent changes to appendStringInfo() handling broke
it. The old version converted a NULL string into a "<>".
Handing a NULL for %s to vsnprintf() is implementation
dependent (some put nothing, some put (null) and some might
simply crash - but none puts "<>").

There is a new macro stringStringInfo(s) in include/lib.h
which checks for NULL and substitutes by "<>". All string
arguments to appendStringInfo() are now embedded into that
(also in commands/explain.c).

Regression tests for select_views, rules and plpgsql are O.K.
again.

Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#======================================== jwieck(at)debis(dot)com (Jan Wieck) #

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas G. Lockhart 1998-12-18 15:18:32 Re: [HACKERS] Re: [GENERAL] date_part bug?
Previous Message Thomas G. Lockhart 1998-12-18 15:00:13 Re: [HACKERS] CURRENT: crash in select_view regression test...