| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Remove unused #include's in src/backend/commands/* |
| Date: | 2025-10-09 13:36:45 |
| Message-ID: | ln2ogaopaucmgpcztfb4xukpv3bcqspuoowa5urvtmpbz53uhh@6jrzttvn46bd |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2025-10-09 16:26:20 +0300, Aleksander Alekseev wrote:
> > > Apparently touching collationcmds.c, restricted_token.c and
> > > fe-auth-oauth.c was a mistake. Here is the corrected patch v4.
> >
> > Clearly this approach is not bulletproof enough to actually yield something
> > reliable enough to actually be applied.
>
> I'm open to suggestions. I only have three machines to test my patches
> (Linux, MacOS and Windows, and I've just discovered that the master
> branch doesn't compile on Windows 11 at the moment).
Manually analyze each of the removed includes by hand. Fix all the issues that
lead to iwyu giving you wrong suggestions. Test it with CI in your own repo.
Or just don't do it.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2025-10-09 13:40:32 | Re: Invalid pointer access in logical decoding after error |
| Previous Message | Aleksander Alekseev | 2025-10-09 13:26:20 | Re: [PATCH] Remove unused #include's in src/backend/commands/* |