From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Subject: | Re: [PATCH] Remove unused #include's in src/backend/commands/* |
Date: | 2025-10-09 14:04:16 |
Message-ID: | CAJ7c6TO5cRvaLjNj4hdf8i+rSc27+7pDcLRtan4BQSE3wvr=Fw@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Andres,
> Manually analyze each of the removed includes by hand. Fix all the issues that
> lead to iwyu giving you wrong suggestions.
Well, I did, and played it as safe as I could in fact. Unfortunately
given the amount of (build systems * supported hardware * supported
operating systems * OS versions * build flags * #ifdefs in the code *
compilers) this is a difficult problem to reason about, for both
people and IWYU.
> Test it with CI in your own repo.
I see your point. I thought I tested the patch good enough locally to
make it pass on cfbot the first time, but clearly I was wrong. If
cfbot will complain again I'll continue experimenting with the patch
in my own repository.
Thanks for your feedback and apologies for the noise on the mailing
list. It was not intended.
--
Best regards,
Aleksander Alekseev
From | Date | Subject | |
---|---|---|---|
Next Message | Chao Li | 2025-10-09 14:06:22 | Re: Add downloaded files to gitignore |
Previous Message | Álvaro Herrera | 2025-10-09 13:47:20 | Re: [PATCH] Remove unused #include's in src/backend/commands/* |