Re: [Patch] Windows relation extension failure at 2GB and 4GB

From: Andres Freund <andres(at)anarazel(dot)de>
To: Bryan Green <dbryan(dot)green(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [Patch] Windows relation extension failure at 2GB and 4GB
Date: 2025-11-12 14:19:34
Message-ID: kwxpdgdf5qftwp57mqwzcjjjallmuyvatwmagj6qrntbsv2ugm@kmunmiku7xvl
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2025-11-11 13:22:49 -0600, Bryan Green wrote:
> diff --git a/src/test/modules/test_large_files/README b/src/test/modules/test_large_files/README
> new file mode 100644
> index 0000000000..d7caae49e6
> --- /dev/null
> +++ b/src/test/modules/test_large_files/README
> @@ -0,0 +1,53 @@
> +Test Module for Windows Large File I/O
> +
> +This test module provides functions to test PostgreSQL's ability to
> +handle files larger than 4GB on Windows.
> +
> +Requirements
> +
> +- Windows platform
> +- PostgreSQL built with segment size greater than 2GB
> +- NTFS filesystem (for sparse file support)

I don't think this test should only run on windows. That a) makes it harder to
maintain for non-windows devs b) assumes that only windows could ever have
issues.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2025-11-12 14:26:51 Re: Add tab completion support for WAIT FOR command
Previous Message Amit Langote 2025-11-12 14:17:43 Re: generic plans and "initial" pruning