Re: [Patch] Windows relation extension failure at 2GB and 4GB

From: Bryan Green <dbryan(dot)green(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [Patch] Windows relation extension failure at 2GB and 4GB
Date: 2025-11-11 19:22:49
Message-ID: a7c983fc-4416-4777-a1ba-590fc06884c0@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/8/2025 3:40 AM, Michael Paquier wrote:
> On Fri, Nov 07, 2025 at 12:32:21PM +0900, Michael Paquier wrote:
>> On Fri, Nov 07, 2025 at 03:56:07PM +1300, Thomas Munro wrote:
>>> (It's signed per POSIX and on Windows so I assume you meant to write 2GB here.)
>>
>> Yes, right..
>
> So, please find attached a patch that adds a check for large files in
> meson as we do now in ./configure, for a backpatch down to v16 (once
> the branch freeze is lifted next week of course).
>
> Thoughts?
> --
> Michael
I have attached v4 of the patch after correcting some whitespace errors
and a struct that didn't need the pgoff_t modification as requested by
Thomas. I also have attached Michael's patch where both patches can be
found by cfbot for the commitfest.

--
Bryan Green
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
v4-0001-Add-Windows-support-for-large-files.patch text/plain 40.2 KB
0001-Add-check-for-large-files-in-meson.build.patch text/plain 1.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-11-11 19:28:08 Re: Improve LWLock tranche name visibility across backends
Previous Message Nathan Bossart 2025-11-11 18:48:39 Re: Trigger more frequent autovacuums of heavy insert tables