Re: Win32 timezone matching

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Win32 timezone matching
Date: 2010-04-06 22:27:51
Message-ID: k2q9837222c1004061527sebaff5c5ydc50b4448b012fff@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 7, 2010 at 00:02, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Oh, another thought here: what is the effect of the combination of this
> with your other proposal to add more timezones to the list?  In
> particular, what happens if we use the extended list in an unpatched
> system that doesn't know about those new zone names?  I'm wondering
> if we *have* to make this change for that to behave sanely.  We might
> also need to consider whether we want any log chatter in such a case.

No, as long as the key *exists* we've always moved on to the next one
if it didn't match. It's only when it doesn't exist at all that we
aborted.

And if the system doesn't know about those names, it'll never show up.
We're mapping *from* windows to *us*. So if the zones aren't in
windows at all, there is no way for windows to give us that name.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2010-04-06 22:31:47 Re: pg_filedump strangeness
Previous Message Tom Lane 2010-04-06 22:19:19 Re: pg_filedump strangeness