Re: pgsql: Prevent invalidation of newly synced replication slots.

Hi,

On 2026-01-28 05:16:13 +1300, Thomas Munro wrote:
> On Wed, Jan 28, 2026 at 3:59 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > I imagine this is going to break CI for everybody else too, as well as cfbot.
>
> Just by the way, on that last point, we trained cfbot to watch out for
> CI pass/fail in this account:
>
> https://github.com/postgres/postgres/commits/master/
>
> and then use the most recent pass as the base commit when applying
> patches to make test branches. So if master is broken for a while, it
> no longer takes all the cfbot runs with it. Mentioning just in case
> anyone is confused by that...

Ah. I was indeed confused by that for a bit.

> But I wonder if you can't rename("old", "new") where "new" is a file that
> has already been unlinked (or renamed over) that someone still holds open,
> or something like that...

I don't see a source of that that would be specific to this test though :(. We
do wait for pg_basebackup to have shut down, which wrote backup.label (which
was "manifactured" during streaming by basebackup.c).

Perhaps we should crank up log level in the test? No idea if it'll help, but
right now I don't even know where to start looking.

Greetings,

Andres Freund