Re: pgsql: Prevent invalidation of newly synced replication slots.

From: Greg Burd <greg(at)burd(dot)me>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Prevent invalidation of newly synced replication slots.
Date: 2026-01-27 16:53:38
Message-ID: 54F8BC8B-6F9D-4B91-8B68-AA02B7643B94@burd.me
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


> On Jan 27, 2026, at 10:49 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> This commit has broken CI for me.
>
>> Hmm, I wonder why the buildfarm seems fine with it ... I'm prepared
>> to believe a Windows-only problem, but at least hamerkop has run
>> since 851f664.
>
> D'oh: hamerkop doesn't run any TAP tests, let alone ones that require
> --enable-injection-points. So that success proves nothing.
>
> Our other Windows animals (drongo, fairywren, unicorn) seem to be
> configured with -Dtap_tests=enabled, but nothing about injection
> points, so they will also skip 046_checkpoint_logical_slot.
> Seems like a bit of a blind spot in the buildfarm.
>
> regards, tom lane
>

I'll see if I can update unicorn today to enable injection points to add some coverage on Win11/ARM64/MSVC. No promises that will be diagnostic at all, but it seems like a good idea.

-Dinjection_points=true

-greg

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2026-01-27 17:11:23 Re: pgsql: Prevent invalidation of newly synced replication slots.
Previous Message Andres Freund 2026-01-27 16:37:56 Re: pgsql: Prevent invalidation of newly synced replication slots.

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2026-01-27 16:53:41 Re: Flush some statistics within running transactions
Previous Message David G. Johnston 2026-01-27 16:51:58 Re: docs: warn about post-data-only schema dumps with parallel restore.