Re: Remove mention in docs that foreign keys on partitioned tables are not supported

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove mention in docs that foreign keys on partitioned tables are not supported
Date: 2018-06-29 13:05:32
Message-ID: ff9d5219-cf84-ea2a-e841-d26b625cab3f@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06/29/2018 02:30 PM, Robert Haas wrote:
> On Wed, Jun 27, 2018 at 10:26 PM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> By the way, picking up on the word "inherited" in the error message shown
>> above, I wonder if you decided against using similar terminology
>> intentionally.
>
> Good question.
>
>> I guess the thinking there is that the terminology being
>> used extensively with columns and constraints ("inherited column/check
>> constraint cannot be dropped", etc.) is just a legacy of partitioning
>> sharing implementation with inheritance.
>
> It seems to me that we can talk about things being inherited by
> partitions even if we're calling the feature partitioning, rather than
> inheritance. Maybe that's confusing, but then again, maybe it's not
> that confusing.
>

my 2c: I don't think it's confusing. Inheritance is a generic concept,
not attached exclusively to the "table inheritance". If you look at docs
from other databases, you'll see "partition inherits" all the time.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2018-06-29 13:11:37 Re: POC: GROUP BY optimization
Previous Message Etsuro Fujita 2018-06-29 12:51:04 Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled.