| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: enable fallthrough warnings on clang |
| Date: | 2026-02-23 07:32:34 |
| Message-ID: | ff96a067-dae4-4455-922f-952ddf0a1fa7@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21.01.26 12:34, Peter Eisentraut wrote:
> On 20.01.26 16:03, Jelte Fennema-Nio wrote:
>> On Tue, 20 Jan 2026 at 12:16, Peter Eisentraut <peter(at)eisentraut(dot)org>
>> wrote:
>>> So my proposal is that we wrap the appropriate attribute into a
>>> pg_fallthrough macro, and replace the current comments with that.
>>
>> All looks okay to me. The only thing that stood out is that it checks
>> for C++ with __cpp_attributes instead of __cplusplus. Is it really
>> worth using this more specific attribute? Given that we're already
>> requiring C++11 and afaict all C++11 compilers should support the
>> general notion of attributes.
>
> I agree. I will make that change.
I have committed this patch set. I also added a test into the C++ module.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2026-02-23 08:04:55 | Re: Non-text mode for pg_dumpall |
| Previous Message | Peter Eisentraut | 2026-02-23 07:24:22 | Re: Don't cast away const where possible |