| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: enable fallthrough warnings on clang |
| Date: | 2026-01-21 11:34:42 |
| Message-ID: | 955ddaa3-d6e8-4d87-a368-ef9f25960d4e@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20.01.26 16:03, Jelte Fennema-Nio wrote:
> On Tue, 20 Jan 2026 at 12:16, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>> So my proposal is that we wrap the appropriate attribute into a
>> pg_fallthrough macro, and replace the current comments with that.
>
> All looks okay to me. The only thing that stood out is that it checks
> for C++ with __cpp_attributes instead of __cplusplus. Is it really
> worth using this more specific attribute? Given that we're already
> requiring C++11 and afaict all C++11 compilers should support the
> general notion of attributes.
I agree. I will make that change.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2026-01-21 11:41:31 | Re: Skipping schema changes in publication |
| Previous Message | Peter Eisentraut | 2026-01-21 11:31:27 | Re: Fix accidentally cast away qualifiers |