Re: Wrong argument name in error message from attribute_stats functions

From: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wrong argument name in error message from attribute_stats functions
Date: 2026-07-13 13:20:28
Message-ID: ff677e97-9f0e-4973-a3c1-4cebeddac41f@tantorlabs.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/10/26 15:32, Fujii Masao wrote:

> On Fri, Jul 10, 2026 at 9:11 PM Ilia Evdokimov
> <ilya(dot)evdokimov(at)tantorlabs(dot)com> wrote:
>> Hi,
>>
>> While using pg_clear_attribute_stats() I noticed weird printing:
>>
>> ```
>> CREATE TABLE t(a int);
>> SELECT pg_clear_attribute_stats(NULL, 't', 'a', false);
>> ERROR: argument "relation" must not be null
>> ```
>>
>> NULL was passed for `schemaname`, not for a `relation` argument. This
>> comes from cleararginfo[], where both the schema and relname entries are
>> labeled `relation`.
>>
>> In v1-patch I propose naming these the same way `pg_proc.dat` does, i.e.
>> `schemaname` and `relname`.
> Thanks for the patch! LGTM.

Since Beta 2 is scheduled for July 16, it might be worth getting this
fixed before then. Incorrect error messages can mislead users during
debugging.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC,
https://tantorlabs.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Rui Zhao 2026-07-13 13:29:45 Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statement
Previous Message vignesh C 2026-07-13 12:54:55 Re: Fix publisher-side sequence permission reporting