Re: Wrong argument name in error message from attribute_stats functions

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wrong argument name in error message from attribute_stats functions
Date: 2026-07-10 12:32:32
Message-ID: CAHGQGwGDpHB4eKnk=GPhOZb1tCq0hKnwQmL4Aj7aprnL7itX1w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 10, 2026 at 9:11 PM Ilia Evdokimov
<ilya(dot)evdokimov(at)tantorlabs(dot)com> wrote:
>
> Hi,
>
> While using pg_clear_attribute_stats() I noticed weird printing:
>
> ```
> CREATE TABLE t(a int);
> SELECT pg_clear_attribute_stats(NULL, 't', 'a', false);
> ERROR: argument "relation" must not be null
> ```
>
> NULL was passed for `schemaname`, not for a `relation` argument. This
> comes from cleararginfo[], where both the schema and relname entries are
> labeled `relation`.
>
> In v1-patch I propose naming these the same way `pg_proc.dat` does, i.e.
> `schemaname` and `relname`.

Thanks for the patch! LGTM.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2026-07-10 12:34:54 Re: s/pg_attribute_always_inline/pg_always_inline/?
Previous Message Ilia Evdokimov 2026-07-10 12:11:17 Wrong argument name in error message from attribute_stats functions