| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: pg_dump emits ALTER TABLE ONLY partitioned_table |
| Date: | 2017-05-09 01:13:45 |
| Message-ID: | ff0b4014-28d0-7937-59c9-075aad27e976@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/05/08 12:42, Stephen Frost wrote:
> Amit,
>
> * Amit Langote (Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp) wrote:
>> Thanks for committing the patch after improving it quite a bit, and sorry
>> that I couldn't reply promptly during the last week due to vacation.
>
> No worries, hopefully you have an opportunity to review the additional
> changes I made and understand why they were necessary. Certainly, feel
> free to reach out if you have any questions or notice anything else
> which should be improved.
Do you intend to push the other patch to add regression tests for the
non-inherited constraints? Here it is attached again for you to look over.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Improve-test-coverage-of-partition-constraints.patch | text/x-diff | 6.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-05-09 03:23:34 | Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling) |
| Previous Message | Masahiko Sawada | 2017-05-09 00:32:01 | Re: Logical replication - TRAP: FailedAssertion in pgstat.c |