Re: pg_dump emits ALTER TABLE ONLY partitioned_table

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Date: 2018-12-08 00:17:36
Message-ID: 20181208001735.GT3415@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Amit Langote (Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp) wrote:
> On 2017/05/08 12:42, Stephen Frost wrote:
> > * Amit Langote (Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp) wrote:
> >> Thanks for committing the patch after improving it quite a bit, and sorry
> >> that I couldn't reply promptly during the last week due to vacation.
> >
> > No worries, hopefully you have an opportunity to review the additional
> > changes I made and understand why they were necessary. Certainly, feel
> > free to reach out if you have any questions or notice anything else
> > which should be improved.
>
> Do you intend to push the other patch to add regression tests for the
> non-inherited constraints? Here it is attached again for you to look over.

In a blast from the past, I had a long-lost note about trying to push
this that I just stumbled over.

Apologies for it getting lost in the cracks. I've rebased it and will
plan to push it later this weekend, barring objections.

Thanks!

Stephen

Attachment Content-Type Size
addl-partition-tests-v1_master.patch text/x-diff 8.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2018-12-08 00:25:11 Re: Statement-level rollback
Previous Message Stephen Frost 2018-12-07 23:25:29 Dead code in toast_fetch_datum_slice?