| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: CI slowdown due to PG_TEST_INITDB_EXTRA_OPTS |
| Date: | 2026-11-20 07:49:19 |
| Message-ID: | fdcacaca-504c-4a16-9c4a-94b8f1ec991d@iki.fi |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19/11/2026 09:57, Nazir Bilal Yavuz wrote:
> On Wed, 18 Nov 2026 at 23:07, Andres Freund <andres(at)anarazel(dot)de> wrote:
>>
>> On 2026-11-18 16:14:28 +0200, Heikki Linnakangas wrote:
>>> On 23/09/2026 21:42, Jelte Fennema-Nio wrote:
>>>> On Wed, 22 Jul 2026 at 08:56, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>>>>> Attached is an attempt to implement 'PG_TEST_SERVER_POSTGRES_OPTS'.
>>>>
>>>> I'm starting to get kinda annoyed that this (or my earlier version)
>>>> hasn't been committed yet, or at least made some progress. There's a
>>>> trivial way to improve CI runtime by 25-30%. Why has this patch been
>>>> in limbo for more than 2 months?
>>
>>> Committed, thanks!
>>
>> Thanks for doing that!
>>
>> I'd like to see this backpatched, in preparation to backpatching CI. I don't
>> want to start out with a larger set of differences than necessary.
>
> I think this makes sense.
>
> There is one problem, 'PG_TEST_INITDB_EXTRA_OPTS' is introduced in the
> PG_17 [1] and not backpatched to 15 (where CI introduced). Because of
> this, 'PG_TEST_INITDB_EXTRA_OPTS' mentions are removed from
> REL_[15,16] patch for now. Backpatching [1] is another option, though.
>
> [1] https://github.com/postgres/postgres/commit/995d400ceca3e552f84fe19f150fb03327bdc0c2
I considered backpatching to 19, the patch would've applied cleanly. I
didn't check branches older than that. But the fact that it added a new
option to pg_regress gave me pause. That feels like a new feature, also
visible to users, rather than just CI changes. I wouldn't object to
backpatching it anyway, but that's why I didn't do it right away.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-11-20 07:49:48 | Re: Report buffer access strategies in EXPLAIN |
| Previous Message | Michael Paquier | 2026-11-20 07:40:53 | Re: Checkpoints stuck after a failed bulk write inside a savepoint |