| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: CI slowdown due to PG_TEST_INITDB_EXTRA_OPTS |
| Date: | 2026-11-19 07:57:09 |
| Message-ID: | CAN55FZ0qYukeM0q2iqvEBOGtuxLC-chZ9ymuOXTyu1TgxZT-+A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Wed, 18 Nov 2026 at 23:07, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2026-11-18 16:14:28 +0200, Heikki Linnakangas wrote:
> > On 23/09/2026 21:42, Jelte Fennema-Nio wrote:
> > > On Wed, 22 Jul 2026 at 08:56, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> > > > Attached is an attempt to implement 'PG_TEST_SERVER_POSTGRES_OPTS'.
> > >
> > > I'm starting to get kinda annoyed that this (or my earlier version)
> > > hasn't been committed yet, or at least made some progress. There's a
> > > trivial way to improve CI runtime by 25-30%. Why has this patch been
> > > in limbo for more than 2 months?
>
> > Committed, thanks!
>
> Thanks for doing that!
>
> I'd like to see this backpatched, in preparation to backpatching CI. I don't
> want to start out with a larger set of differences than necessary.
I think this makes sense.
There is one problem, 'PG_TEST_INITDB_EXTRA_OPTS' is introduced in the
PG_17 [1] and not backpatched to 15 (where CI introduced). Because of
this, 'PG_TEST_INITDB_EXTRA_OPTS' mentions are removed from
REL_[15,16] patch for now. Backpatching [1] is another option, though.
[1] https://github.com/postgres/postgres/commit/995d400ceca3e552f84fe19f150fb03327bdc0c2
--
Regards,
Nazir Bilal Yavuz
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| REL_15-16-Add-PG_TEST_SERVER_POSTGRES_OPTS.patch | text/x-patch | 3.8 KB |
| REL_17-18-Add-PG_TEST_SERVER_POSTGRES_OPTS.patch | text/x-patch | 4.5 KB |
| REL_19-Add-PG_TEST_SERVER_POSTGRES_OPTS.patch | text/x-patch | 6.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2026-11-19 08:05:41 | Re: Detect mismatched subscription and replication slot properties |
| Previous Message | Aleksander Alekseev | 2026-11-19 07:45:54 | Re: [PATCH] Fix leak when a plpgsql exception block catches an error from CALL |