| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Remove some useless casts to (void *) |
| Date: | 2023-02-02 22:22:27 |
| Message-ID: | fd9adf5d-b1aa-e82f-e4c7-263c30145807@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I have found that in some corners of the code some calls to standard C
functions are decorated with casts to (void *) for no reason, and this
code pattern then gets copied around. I have gone through and cleaned
this up a bit, in the attached patches.
The involved functions are: repalloc, memcpy, memset, memmove, memcmp,
qsort, bsearch
Also hash_search(), for which there was a historical reason (the
argument used to be char *), but not anymore.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-useless-casts-to-void-hash_search.patch | text/plain | 40.2 KB |
| 0002-Remove-useless-casts-to-void-repalloc.patch | text/plain | 7.0 KB |
| 0003-Remove-useless-casts-to-void-memcpy.patch | text/plain | 10.2 KB |
| 0004-Remove-useless-casts-to-void-memset.patch | text/plain | 5.4 KB |
| 0005-Remove-useless-casts-to-void-memmove.patch | text/plain | 1.1 KB |
| 0006-Remove-useless-casts-to-void-memcmp.patch | text/plain | 767 bytes |
| 0007-Remove-useless-casts-to-void-qsort.patch | text/plain | 25.8 KB |
| 0008-Remove-useless-casts-to-void-bsearch.patch | text/plain | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-02-02 22:39:19 | Re: Weird failure with latches in curculio on v15 |
| Previous Message | Thomas Munro | 2023-02-02 22:14:40 | Re: Move defaults toward ICU in 16? |