| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove some useless casts to (void *) |
| Date: | 2023-02-02 23:59:44 |
| Message-ID: | CADkLM=edJ4DBQQn1jZcDs9Lhn+s3o5P7PT3y3y_QRPcwQ8s3SA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 2, 2023 at 5:22 PM Peter Eisentraut <
peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> I have found that in some corners of the code some calls to standard C
> functions are decorated with casts to (void *) for no reason, and this
> code pattern then gets copied around. I have gone through and cleaned
> this up a bit, in the attached patches.
>
> The involved functions are: repalloc, memcpy, memset, memmove, memcmp,
> qsort, bsearch
>
> Also hash_search(), for which there was a historical reason (the
> argument used to be char *), but not anymore.
+1
All code is example code.
Applies.
Passes make check world.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2023-02-03 00:41:12 | Re: Support logical replication of DDLs |
| Previous Message | Peter Geoghegan | 2023-02-02 23:16:32 | Re: Amcheck verification of GiST and GIN |