| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [19] CREATE SUBSCRIPTION ... SERVER |
| Date: | 2026-03-18 19:06:48 |
| Message-ID: | fd49b44dc65da8e71ab20c1cf1ec7e65921c20f5.camel@j-davis.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 2026-03-14 at 15:55 -0700, Jeff Davis wrote:
> Attached series including patches to address Andres's and Amit's
> comments, too.
Committed two patches.
New patch 0004: fixes missing dependencies from the FDW to the
connection function. There's a related pre-existing issue with the
dependency from the FDW to the handler function, which I will post as a
separate backportable bugfix.
I'd still like to find a good way to add pg_dump tests. The only idea I
have now is to build the test function into core postgres (without
pg_proc entry), which might be worthwhile.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| v23-0001-Temp-context-for-maybe_reread_subscription.patch | text/x-patch | 6.9 KB |
| v23-0002-Refactor-to-remove-ForeignServerName.patch | text/x-patch | 7.3 KB |
| v23-0003-Add-pg_dump-tests-related-to-CREATE-SUBSCRIPTION.patch | text/x-patch | 3.0 KB |
| v23-0004-Add-dependency-entry-for-FDW-connection-function.patch | text/x-patch | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-03-18 19:10:07 | Re: Improve hash join's handling of tuples with null join keys |
| Previous Message | Daniel Gustafsson | 2026-03-18 19:03:49 | Re: Serverside SNI support in libpq |