| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Joel Jacobson" <joel(at)compiler(dot)org> |
| Cc: | "Chao Li" <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve hash join's handling of tuples with null join keys |
| Date: | 2026-03-18 19:10:07 |
| Message-ID: | 940201.1773861007@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Joel Jacobson" <joel(at)compiler(dot)org> writes:
> I've tested v3-0001 and v3-0002 and can confirm the bug introduced
> in v3-0001 is fixed in v3-0002:
Thanks for testing!
I noticed from the cfbot that this patch wasn't building anymore.
nodeHash[join].c now need explicit inclusions of utils/tuplestore.h,
presumably as a result of Alvaro's recent header-inclusion cleanups.
Here's a v4 that fixes that; no other changes.
We're getting towards the end of the v19 development cycle, so
I'm planning to push this soon if there's not objections.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Improve-hash-join-s-handling-of-tuples-with-null-.patch | text/x-diff | 36.6 KB |
| v4-0002-Fix-tuple-counting-issues-in-hash-joins.patch | text/x-diff | 7.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Srinath Reddy Sadipiralla | 2026-03-18 19:12:19 | Re: Adding REPACK [concurrently] |
| Previous Message | Jeff Davis | 2026-03-18 19:06:48 | Re: [19] CREATE SUBSCRIPTION ... SERVER |