Re: Things I don't like about \du's "Attributes" column

From: Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <jim(dot)nasby(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Things I don't like about \du's "Attributes" column
Date: 2024-02-18 11:14:21
Message-ID: fd1efe55-1f5b-4e3a-8933-d2d9a2509dd5@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 17.02.2024 00:37, David G. Johnston wrote:
> On Mon, Feb 12, 2024 at 2:29 PM Pavel Luzanov
> <p(dot)luzanov(at)postgrespro(dot)ru> wrote:
>
> regress_du_role1 | no | Inherit | no | 2024-12-31 00:00:00+03(invalid) | 50 | Group role without password but with valid until
> regress_du_role2 | yes | Inherit | yes | | Not allowed | No connections allowed
> regress_du_role3 | yes | | yes | | 10 | User without attributes
> regress_du_su | yes | Superuser +| yes | | 3(ignored) | Superuser but with connection limit
>
>
> Per the recent bug report, we should probably add something like
> (ignored) after the 50 connections for role1 since they are not
> allowed to login so the value is indeed ignored.

Hm, but the same logic applies to "Password?" and "Valid until" for role1 without login attribute.
The challenge is how to display it for unprivileged users. But they can't see password information.
So, displaying 'Valid until' as '(irrelevant)' for privileged users and real value for others looks badly.

What can be done in this situation.
0. Show different values as described above.
1. Don't show 'Valid until' for unprivileged users at all. The same logic as for 'Password?'.
With possible exception: user can see 'Valid until' for himself.
May be too complicated?

2. Tom's advise:

> Not sure it's worth worrying about

Show real values for 'Valid until' and 'Connection limit' without any hints.

3. The best solution, which I can't see now.

--
Pavel Luzanov
Postgres Professional:https://postgrespro.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-02-18 11:36:09 Re: PGC_SIGHUP shared_buffers?
Previous Message Andy Fan 2024-02-18 09:07:50 Re: Properly pathify the union planner