Re: documenting the backup manifest file format

From: David Steele <david(at)pgmasters(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>
Subject: Re: documenting the backup manifest file format
Date: 2020-04-14 17:33:44
Message-ID: fc1f2014-db09-9795-b494-92d6ac96eb0e@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/14/20 1:27 PM, Alvaro Herrera wrote:
> On 2020-Apr-14, David Steele wrote:
>
>> On 4/14/20 12:56 PM, Robert Haas wrote:
>>
>>> Hmm, did David suggest that before? I don't recall for sure. I think
>>> he had some suggestion, but I'm not sure if it was the same one.
>>
>> "I'm also partial to using epoch time in the manifest because it is
>> generally easier for programs to work with. But, human-readable doesn't
>> suck, either."
>
> Ugh. If you go down that road, why write human-readable contents at
> all? You may as well just use a binary format. But that's a very
> slippery slope and you won't like to be in the bottom -- I don't see
> what that gains you. It's not like it's a lot of work to parse a
> timestamp in a non-internationalized well-defined human-readable format.

Well, times are a special case because they are so easy to mess up. Try
converting ISO-8601 to epoch time using the standard C functions on a
system where TZ != UTC. Fun times.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-04-14 18:00:19 Re: [bug] Table not have typarray when created by single user mode
Previous Message Alvaro Herrera 2020-04-14 17:27:31 Re: documenting the backup manifest file format