Re: Fix background writer processing locking in README

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Henrik TJ <henrik(at)0x48(dot)dk>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix background writer processing locking in README
Date: 2026-11-19 14:19:52
Message-ID: fc1eef6c-db89-4698-9efe-fa3eb15c624c@iki.fi
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 28/04/2026 17:25, Henrik TJ wrote:
> Hi
>
> I was reading through src/backend/storage/buffer/README, and the
> paragraph about writing out buffers seems not to have been updated after
> starting to use the share-exclusive lock level, commit 82467f627bd4.
>
> The paragraph in question:
>
> The background writer takes shared content lock on a buffer while
> writing it
> out (and anyone else who flushes buffer contents to disk must do so too).
> This ensures that the page image transferred to disk is reasonably
> consistent.
> We might miss a hint-bit update or two but that isn't a problem, for the
> same
> reasons mentioned under buffer access rules.
>
> The attached patch updates this to use shared-exclusive, and removes the
> consistency bit. Arguably the entire paragraph could be removed, as the
> issue is covered earlier in the document, but I tried to keep the doc
> mostly as-is.

Committed this with some further copy-editing. The surrounding
paragraphs were pretty outdated too, so I updated them too.

Better late than never :-). Thanks!

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou 2026-11-19 14:21:27 Re: Proposal: Conflict log history table for Logical Replication
Previous Message Peter Eisentraut 2026-11-19 14:16:50 Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore