| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Subject: | Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore |
| Date: | 2026-11-19 14:16:50 |
| Message-ID: | aeba1063-f304-4d32-8d15-282188b14e4b@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09.11.26 10:28, Peter Eisentraut wrote:
> On 04.11.26 22:38, Jelte Fennema-Nio wrote:
>> On Wed, 4 Nov 2026 at 12:08, Peter Eisentraut <peter(at)eisentraut(dot)org>
>> wrote:
>>> If we want to make this behavior change, then this might be better done
>>> as a separate patch before the refactoring.
>>
>> Agreed. I had somehow missed that there were different sigjump targets
>> and not all of them set the cancel_requested flag. Attached is a new
>> patchset with this behaviour change done first explicitely. Because I
>> agree it's a bug that Ctrl+C in a promt doesn't stop the script.
>
> I have committed the 0001 patch and I will continue looking at the rest.
Committed 0002 "psql: Replace cancel_pressed with CancelRequested" also.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-11-19 14:19:52 | Re: Fix background writer processing locking in README |
| Previous Message | Sami Imseih | 2026-11-19 13:55:40 | Re: Avoid redundant BitmapAnd with a clauseless partial index |