Re: Centralised architecture detection

From: "Greg Burd" <greg(at)burd(dot)me>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Thomas Munro" <thomas(dot)munro(at)gmail(dot)com>
Cc: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Andres Freund" <andres(at)anarazel(dot)de>, "Lukas Fittl" <lukas(at)fittl(dot)com>, "John Naylor" <johncnaylorls(at)gmail(dot)com>, "Bryan Green" <dbryan(dot)green(at)gmail(dot)com>
Subject: Re: Centralised architecture detection
Date: 2026-07-01 11:43:16
Message-ID: f8b89c60-e5e3-47c0-b63e-eceaf6a9f83e@app.fastmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Tue, Jun 30, 2026, at 9:11 PM, Tom Lane wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
>> It looks like they didn't want __riscv32 and __riscv64?
>> https://groups.google.com/a/groups.riscv.org/g/sw-dev/c/E8EO-Fd4t3s
>
> Sigh ... another project that is convinced that they're smarter than
> everybody else and conforming to common practice is an anti-pattern.
>
> Based on that thread, I'm thinking
>
> ...
> #elif defined(__riscv)
> #if SIZEOF_VOID_P == 8
> #define __riscv64__ 1
> #else
> #define __riscv__ 1
> #endif
> #elif defined(__s390__)
> ...

I don't see SIZEOF_VOID_P but I do find:

#define __SIZEOF_POINTER__ 8

-greg

> I'd rather rely on our own pointer-size determination than YA
> magic compiler-defined symbol.
>
> regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2026-07-01 11:57:14 Re: Fix mismatched deallocation functions
Previous Message Greg Burd 2026-07-01 11:39:40 Re: Centralised architecture detection