Re: Centralised architecture detection

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Greg Burd <greg(at)burd(dot)me>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Lukas Fittl <lukas(at)fittl(dot)com>, John Naylor <johncnaylorls(at)gmail(dot)com>, Bryan Green <dbryan(dot)green(at)gmail(dot)com>
Subject: Re: Centralised architecture detection
Date: 2026-07-01 01:11:38
Message-ID: 3093282.1782868298@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> It looks like they didn't want __riscv32 and __riscv64?
> https://groups.google.com/a/groups.riscv.org/g/sw-dev/c/E8EO-Fd4t3s

Sigh ... another project that is convinced that they're smarter than
everybody else and conforming to common practice is an anti-pattern.

Based on that thread, I'm thinking

...
#elif defined(__riscv)
#if SIZEOF_VOID_P == 8
#define __riscv64__ 1
#else
#define __riscv__ 1
#endif
#elif defined(__s390__)
...

I'd rather rely on our own pointer-size determination than YA
magic compiler-defined symbol.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Feng Wu 2026-07-01 01:24:08 [PATCH] Avoid internal error for invalid interval typmods
Previous Message Michael Paquier 2026-07-01 01:09:14 Re: [PATCH] doc: clarify pg_stat_lock.fastpath_exceeded scope