Re: logical replication worker and statistics

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Noah Misch <noah(at)leadboat(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: logical replication worker and statistics
Date: 2017-04-10 16:50:54
Message-ID: f88ee420-a8c5-cb1b-1acc-317fea376620@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/10/17 05:49, Stas Kelvich wrote:
> Here is small patch to call statistics in logical worker. Originally i thought that stat
> collection during logical replication should manually account amounts of changed tuples,
> but seems that it is already smoothly handled on relation level. So call to
> pgstat_report_stat() is enough.

I wonder whether we need a similar call somewhere in tablesync.c. It
seems to work without it, though.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-04-10 16:52:21 Re: logical replication worker and statistics
Previous Message Robert Haas 2017-04-10 16:50:19 Re: Compiler warning in costsize.c