| From: | Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logical replication worker and statistics |
| Date: | 2017-04-10 17:06:26 |
| Message-ID: | 688DE87B-7A41-4EAE-B365-03E827D74B81@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 10 Apr 2017, at 19:50, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> On 4/10/17 05:49, Stas Kelvich wrote:
>> Here is small patch to call statistics in logical worker. Originally i thought that stat
>> collection during logical replication should manually account amounts of changed tuples,
>> but seems that it is already smoothly handled on relation level. So call to
>> pgstat_report_stat() is enough.
>
> I wonder whether we need a similar call somewhere in tablesync.c. It
> seems to work without it, though.
I thought it spins up the same worker from worker.c.
Stas Kelvich
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= | 2017-04-10 17:20:05 | Re: Compiler warning in costsize.c |
| Previous Message | Tom Lane | 2017-04-10 16:57:07 | Re: pg_upgrade vs extension upgrades |