Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much
Date: 2017-10-22 16:11:04
Message-ID: f879f89d-1ea3-0d6a-a40f-4fd60fdce31d@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 10/21/2017 07:33 PM, Michael Paquier wrote:
> On Sun, Oct 22, 2017 at 1:43 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I don't think collecting all the arguments is particularly special ---
>> format() or concat() for instance could possibly use this. You might
>> need an option to say what to do with unknown.
> In this case, we could just use a boolean flag to decide if TEXTOID
> should be enforced or not.

A generic function is going to look a little more complicated than this,
though. The functions as coded assume that the function has a single
variadic argument. But for it to be useful generically it really needs
to be able to work where there are both fixed and variadic arguments (a
la printf style functions).

I guess a simple way would be to make the caller tell the function where
the variadic arguments start, or how many to skip, something like that.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andrew Dunstan 2017-10-22 16:44:58 Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much
Previous Message Andrew Dunstan 2017-10-22 13:19:18 Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-10-22 16:21:44 Re: Allow GiST opcalsses without compress\decompres functions
Previous Message Nikolay Shaplov 2017-10-22 13:24:30 Re: [PATCH] Tests for reloptions