| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Date: | 2017-10-22 13:19:18 |
| Message-ID: | ab2825fd-ecee-04a5-c7df-ca467e20ba02@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 10/21/2017 11:43 AM, Tom Lane wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> Here you go, down to 9.4 where things apply. The same patch can be
>> applied for HEAD/10, 9.5/9.6 and 9.4. The 9.4 version just needs to
>> have the portion for json as the jsonb functions have been added in
>> 9.5, and the json functions are new as of 9.4.
> It doesn't seem very nice to have two identical(?) copies of
> extract_variadic_args, especially since the same functionality
> might be of use elsewhere. I'm almost inclined to say that that
> should go in funcapi.c/.h.
>
>
I guess it's not a problem exposing a new function in funcapi.h in the
stable branches, since this fix needs to be backpatched to 9.4.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2017-10-22 16:11:04 | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Previous Message | marciofarah | 2017-10-22 13:11:43 | BUG #14865: plpythonu |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikolay Shaplov | 2017-10-22 13:24:30 | Re: [PATCH] Tests for reloptions |
| Previous Message | Andrey Borodin | 2017-10-22 11:48:20 | Re: Allow GiST opcalsses without compress\decompres functions |