| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | adrien(dot)nayrat(at)anayrat(dot)info, Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, david(dot)rowley(at)2ndquadrant(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New GUC to sample log queries |
| Date: | 2019-01-04 12:16:48 |
| Message-ID: | f7ad8e2a-f7d0-57b0-9e99-e2d6db95417e@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19/11/2018 14:40, Tomas Vondra wrote:
> On 11/19/18 2:57 AM, Michael Paquier wrote:
>> On Sun, Nov 18, 2018 at 12:18:33PM +0100, Dmitry Dolgov wrote:
>>> Since it's hard to come up with a concise name that will mention sampling rate
>>> in the context of min_duration_statement, I think it's fine to name this
>>> configuration "log_sample_rate", as long as it's dependency from
>>> log_min_duration_statements is clearly explained in the documentation.
>>
>> log_sample_rate looks fine to me as a name.
>
> That seems far too short to me - the name should indicate it applies to
> statement logging. I'd say log_statement_sample_rate is better.
It was committed with this name, but then one has to wonder why it
doesn't also apply to log_statement.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sergei Kornilov | 2019-01-04 12:18:06 | Re: [HACKERS] REINDEX CONCURRENTLY 2.0 |
| Previous Message | David Rowley | 2019-01-04 12:07:48 | Re: pg_dump multi VALUES INSERT |