| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | adrien(dot)nayrat(at)anayrat(dot)info, Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, david(dot)rowley(at)2ndquadrant(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New GUC to sample log queries |
| Date: | 2018-11-19 13:40:03 |
| Message-ID: | 8e0eb6a2-3c67-ca69-9783-a02e7d7bd2b9@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/19/18 2:57 AM, Michael Paquier wrote:
> On Sun, Nov 18, 2018 at 12:18:33PM +0100, Dmitry Dolgov wrote:
>> Since it's hard to come up with a concise name that will mention sampling rate
>> in the context of min_duration_statement, I think it's fine to name this
>> configuration "log_sample_rate", as long as it's dependency from
>> log_min_duration_statements is clearly explained in the documentation.
>
> log_sample_rate looks fine to me as a name.
That seems far too short to me - the name should indicate it applies to
statement logging. I'd say log_statement_sample_rate is better.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-11-19 13:46:30 | Re: New GUC to sample log queries |
| Previous Message | Nikolay Shaplov | 2018-11-19 13:29:40 | Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead |