pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.
Date: 2021-05-17 14:29:18
Message-ID: f706876c-4894-0ba5-6f4d-79803eeea21b@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

If a promotion is triggered while recovery is paused, the paused state ends
and promotion continues. But currently pg_get_wal_replay_pause_state()
returns 'paused' in that case. Isn't this a bug?

Attached patch fixes this issue by resetting the recovery pause state to
'not paused' when standby promotion is triggered.

Thought?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
reset_wal_pause_state_after_promotion_v1.patch text/plain 693 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-05-17 14:38:15 Re: pg_dumpall misses --no-toast-compression
Previous Message Bharath Rupireddy 2021-05-17 14:20:07 Re: postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values?