| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_dumpall misses --no-toast-compression |
| Date: | 2021-05-17 14:38:15 |
| Message-ID: | 2799905.1621262295@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 17 May 2021, at 03:12, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> I have bumped into $subject while playing with this feature, and this
>> can be really useful to be able to reset the compression method for
>> all the tables at restore. The patch is simple but that's perhaps too
>> late for 14, so I am adding it to the next CF.
> I think there is a reasonable case to be made for this fixing an oversight in
> bbe0a81db69bd10bd166907c3701492a29aca294 as opposed to adding a brand new
> feature. Save for --no-synchronized-snapshots all --no-xxx options in pg_dump
> are mirrored in pg_dumpall.
+1, seems more like fixing an oversight than anything else.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nitin Jadhav | 2021-05-17 14:52:25 | Re: Removed extra memory allocations from create_list_bounds |
| Previous Message | Fujii Masao | 2021-05-17 14:29:18 | pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing. |