| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: pg_ctl: Detect current standby state from pg_control |
| Date: | 2016-09-27 00:45:41 |
| Message-ID: | f6f718c7-d9c6-8855-074c-ec91ddb16752@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 9/26/16 7:56 PM, Peter Eisentraut wrote:
> On 9/26/16 8:53 AM, Tom Lane wrote:
>> I think that it's 100% pointless for get_control_dbstate
>> to be worried about transient CRC failures. If writes to pg_control
>> aren't atomic then we have problems enormously larger than whether
>> "pg_ctl promote" throws an error or not.
>
> The new code was designed to handle that, but if we think it's not an
> issue, then we can simplify it. I'm on it.
How about this?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-CRC-check-handling-in-get_controlfile.patch | invalid/octet-stream | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-09-27 00:55:40 | Re: [COMMITTERS] pgsql: pg_ctl: Detect current standby state from pg_control |
| Previous Message | Tom Lane | 2016-09-27 00:23:57 | pgsql: Fix newly-introduced issues in pgbench. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-09-27 00:55:40 | Re: [COMMITTERS] pgsql: pg_ctl: Detect current standby state from pg_control |
| Previous Message | Michael Paquier | 2016-09-27 00:38:08 | Re: wal_segment size vs max_wal_size |