| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: pg_ctl: Detect current standby state from pg_control |
| Date: | 2016-09-26 23:56:24 |
| Message-ID: | 1b5f8f59-e3b4-b158-ef88-d409b413ec43@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 9/26/16 8:53 AM, Tom Lane wrote:
> I think that it's 100% pointless for get_control_dbstate
> to be worried about transient CRC failures. If writes to pg_control
> aren't atomic then we have problems enormously larger than whether
> "pg_ctl promote" throws an error or not.
The new code was designed to handle that, but if we think it's not an
issue, then we can simplify it. I'm on it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-09-27 00:23:57 | pgsql: Fix newly-introduced issues in pgbench. |
| Previous Message | Tom Lane | 2016-09-26 23:25:37 | Re: pgsql: Refactor script execution state machine in pgbench. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-09-27 00:30:02 | Re: Speedup twophase transactions |
| Previous Message | Thomas Munro | 2016-09-26 22:55:07 | Re: VACUUM's ancillary tasks |