Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Shubham Barai <shubhambaraiss(at)gmail(dot)com>
Cc: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Andrew Borodin <amborodin86(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Kevin Grittner <kgrittn(at)gmail(dot)com>
Subject: Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index
Date: 2018-03-27 07:53:12
Message-ID: f6aea691-a91d-9dea-9f0d-689b3f426715@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi!

> Now it looks good for me.  I'm marking it "Ready for committer".

I have a question: why do not CheckForSerializableConflictIn() move into
begining of gistplacetopage()? Seems, it is the single function which actually
changes page and all predicate locking stuff will be placed in single function...

See attached version of patch.
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

Attachment Content-Type Size
Predicate-Locking-in-gist-index_v10.patch text/x-patch 31.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2018-03-27 08:15:20 Re: [HACKERS] MERGE SQL Statement for PG11
Previous Message Michael Paquier 2018-03-27 07:46:30 Re: Problem while setting the fpw with SIGHUP