Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Shubham Barai <shubhambaraiss(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Andrew Borodin <amborodin86(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Kevin Grittner <kgrittn(at)gmail(dot)com>
Subject: Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index
Date: 2018-03-27 08:16:19
Message-ID: 93E87C8E-CCF4-42B5-A9B9-B7C564657AA5@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi1

> 27 марта 2018 г., в 12:53, Teodor Sigaev <teodor(at)sigaev(dot)ru> написал(а):
>
> I have a question: why do not CheckForSerializableConflictIn() move into begining of gistplacetopage()? Seems, it is the single function which actually changes page and all predicate locking stuff will be placed in single function...

gistplacetopage() is called from
1. Buffered build - probably harmless
2. Finish split - i'm not sure about this. It seems to me that it is necessary... then your version is correct.

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2018-03-27 08:24:49 Re: [HACKERS] MERGE SQL Statement for PG11
Previous Message Simon Riggs 2018-03-27 08:15:20 Re: [HACKERS] MERGE SQL Statement for PG11