Re: row filtering for logical replication

From: "Euler Taveira" <euler(at)eulerto(dot)com>
To: Önder Kalacı <onderkalaci(at)gmail(dot)com>
Cc: japin <japinli(at)hotmail(dot)com>, "Michael Paquier" <michael(at)paquier(dot)xyz>, "David Steele" <david(at)pgmasters(dot)net>, "Craig Ringer" <craig(at)2ndquadrant(dot)com>, "Tomas Vondra" <tomas(dot)vondra(at)2ndquadrant(dot)com>, "Amit Langote" <amitlangote09(at)gmail(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: row filtering for logical replication
Date: 2021-02-27 01:35:13
Message-ID: f6566ad9-8979-4056-a4ce-24b09f389ede@www.fastmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 22, 2021, at 9:28 AM, Euler Taveira wrote:
> On Mon, Feb 22, 2021, at 7:45 AM, Önder Kalacı wrote:
>> Thanks for working on this. I did some review and testing, please see my comments below.
> I appreciate your review. I'm working on a new patch set and expect to post it soon.
I'm attaching a new patch set. This new version improves documentation and commit
messages and incorporates a few debug messages. I did a couple of tests and
didn't find issues.

Here are some numbers from my i7 using a simple expression (aid > 0) on table
pgbench_accounts.

$ awk '/row filter time/ {print $9}' postgresql.log | /tmp/stat.pl 99
mean: 33.00 us
stddev: 17.65 us
median: 28.83 us
min-max: [3.48 .. 6404.84] us
percentile(99): 49.66 us
mode: 41.71 us

I don't expect 0005 and 0006 to be included. I attached them to help with some
tests.

--
Euler Taveira
EDB https://www.enterprisedb.com/

Attachment Content-Type Size
0001-Rename-a-WHERE-node.patch text/x-patch 1.7 KB
0002-Row-filter-for-logical-replication.patch text/x-patch 60.9 KB
0003-Print-publication-WHERE-condition-in-psql.patch text/x-patch 1.2 KB
0004-Publication-WHERE-condition-support-for-pg_dump.patch text/x-patch 2.8 KB
0005-Measure-row-filter-overhead.patch text/x-patch 1.5 KB
0006-Debug-messages.patch text/x-patch 1.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2021-02-27 01:48:25 Re: Reducing WaitEventSet syscall churn
Previous Message Mark Wong 2021-02-27 00:58:42 Re: Interest in GSoC 2021 Projects