| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cleaning up historical portability baggage |
| Date: | 2022-07-12 09:26:46 |
| Message-ID: | f639ee9e-d917-c4f4-6c4a-7e9aed36f86a@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12.07.22 03:10, Thomas Munro wrote:
> AFAIK we generally only use pg_whatever() when there's a good reason,
> such as an incompatibility, a complication or a different abstraction
> that you want to highlight to a reader. The reason here was
> temporary: we couldn't implement standard pread/pwrite perfectly on
> ancient HP-UX, but we*can* implement it on Windows, so the reason is
> gone.
>
> These particular pg_ prefixes have only been in our tree for a few
> years and I was hoping to boot them out again before they stick, like
> "Size". I like using standard interfaces where possible for the very
> basic stuff, to de-weird our stuff.
I agree. That's been the established approach.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2022-07-12 09:28:04 | Re: Handle infinite recursion in logical replication setup |
| Previous Message | Masahiko Sawada | 2022-07-12 09:22:45 | Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns |