Re: Handle infinite recursion in logical replication setup

On Tue, Jul 12, 2022 at 9:51 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Jul 12, 2022 at 8:43 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > On Mon, Jul 11, 2022 at 9:11 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >
> > > Here are my review comments for the v30* patches:
> > >
> > > ========
> > > v30-0001
> > > ========
> > >
> > > 1.1 <general>
> > >
> > > I was wondering if it is better to implement a new defGetOrigin method
> > > now instead of just using the defGetString to process the 'origin',
> > > since you may need to do that in future anyway if the 'origin' name is
> > > planned to become specifiable by the user. OTOH maybe you prefer to
> > > change this code later when the time comes. I am not sure what way is
> > > best.
> >
> > I preferred to do that change when the feature is getting extended.
> >
>
> +1.
>
> *
> +$node_C->safe_psql(
> + 'postgres', "
> + DELETE FROM tab");
> +$node_B->safe_psql(
> + 'postgres', "
> + DELETE FROM tab where a = 32");
> +
> +$node_A->wait_for_catchup($subname_BA);
> +$node_B->wait_for_catchup($subname_AB);
>
> Here, don't we need to use node_C instead of node_A for waiting as we
> have performed an operation on node_C?

No need to wait for node_C as we have dropped the subscription before
the delete operation. I have added the comment to make it clear.
The attached v32 patch has the changes for the same.

Regards,
Vignesh