Re: some LLVM function checks missing in meson

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: some LLVM function checks missing in meson
Date: 2024-04-17 08:53:49
Message-ID: f4c1e048-6ae3-4c92-a921-3b5eb05fef23@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13.04.24 10:25, Heikki Linnakangas wrote:
> There's also this in llvmjit.c:
>
>>         if (llvm_opt3_orc)
>>         {
>> #if defined(HAVE_DECL_LLVMORCREGISTERPERF) &&
>> HAVE_DECL_LLVMORCREGISTERPERF
>>             if (jit_profiling_support)
>>                 LLVMOrcUnregisterPerf(llvm_opt3_orc);
>> #endif
>>             LLVMOrcDisposeInstance(llvm_opt3_orc);
>>             llvm_opt3_orc = NULL;
>>         }
>>
>>         if (llvm_opt0_orc)
>>         {
>> #if defined(HAVE_DECL_LLVMORCREGISTERPERF) &&
>> HAVE_DECL_LLVMORCREGISTERPERF
>>             if (jit_profiling_support)
>>                 LLVMOrcUnregisterPerf(llvm_opt0_orc);
>> #endif
>>             LLVMOrcDisposeInstance(llvm_opt0_orc);
>>             llvm_opt0_orc = NULL;
>>         }
>>     }
>
> The autoconf test that set HAVE_DECL_LLVMORCREGISTERPERF was removed in
> commit e9a9843e13. I believe that's a leftover that should also have
> been removed.

Right, that was clearly forgotten. I have removed the dead code.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message m.litsarev 2024-04-17 08:57:47 Re: SQL function which allows to distinguish a server being in point in time recovery mode and an ordinary replica
Previous Message Thomas Munro 2024-04-17 08:52:30 Re: Solaris tar issues, or other reason why margay fails 010_pg_basebackup?