From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Cc: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com> |
Subject: | Re: Outdated replication protocol error? |
Date: | 2021-01-14 07:40:26 |
Message-ID: | f472e434-c10e-0dc0-2554-c05f745f2a2d@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2021/01/12 9:06, Jeff Davis wrote:
> Commit 5ee2197767 (about 4 years old) introduced the error:
>
> "IDENTIFY_SYSTEM has not been run before START_REPLICATION"
>
> But it seems like running START_REPLICATION first works (at least in
> the simple case).
>
> We should either:
>
> 1. Document that IDENTIFY_SYSTEM must always be run before
> START_REPLICATION, and always issue a WARNING if that's not done (an
> ERROR might break existing applications); or
>
> 2. If the commit is out of date and no longer needed, or if it's easy
> enough to fix, just remove the error (and Assert a valid
> ThisTimeLineID).
+1 to remove the error if START_REPLICATION can always work fine without
IDENTIFY_SYSTEM. I found that the error happens when we connect to the standby
and just run START_REPLICATION without IDENTIFY_SYSTEM. But I'm not sure
if IDENTIFY_SYSTEM is actually necessary even in that case.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From | Date | Subject | |
---|---|---|---|
Next Message | Sergey Shinderuk | 2021-01-14 07:44:12 | Re: pg_preadv() and pg_pwritev() |
Previous Message | Kyotaro Horiguchi | 2021-01-14 07:32:27 | Re: Fix typo about WalSndPrepareWrite |