Outdated replication protocol error?

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Simon Riggs <simon(at)2ndQuadrant(dot)com>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>
Subject: Outdated replication protocol error?
Date: 2021-01-12 00:06:28
Message-ID: de4bbf05b7cd94227841c433ea6ff71d2130c713.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Commit 5ee2197767 (about 4 years old) introduced the error:

"IDENTIFY_SYSTEM has not been run before START_REPLICATION"

But it seems like running START_REPLICATION first works (at least in
the simple case).

We should either:

1. Document that IDENTIFY_SYSTEM must always be run before
START_REPLICATION, and always issue a WARNING if that's not done (an
ERROR might break existing applications); or

2. If the commit is out of date and no longer needed, or if it's easy
enough to fix, just remove the error (and Assert a valid
ThisTimeLineID).

Regards,
Jeff Davis

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2021-01-12 00:32:54 Re: Key management with tests
Previous Message Daniel Gustafsson 2021-01-11 23:07:57 Re: Online checksums patch - once again