| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, John Naylor <johncnaylorls(at)gmail(dot)com> |
| Subject: | Re: Reorganize GUC structs |
| Date: | 2025-11-11 07:04:17 |
| Message-ID: | f3e0f766-78bc-450f-8a96-42d2ac101bd4@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07.11.25 16:14, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> Here are a few more small patches to fix related things I found
>> afterwards or in passing.
>
> Looks sane, except that the comparator could do with an extra "const"
> if there's enough room on the line:
>
> + const struct config_generic *ca = *(const struct config_generic *const *) a;
> + const struct config_generic *cb = *(const struct config_generic *const *) b;
>
> Not essential, but casting const away even transiently looks ugly.
committed with that amendment
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-11-11 08:06:49 | Re: Extended Statistics set/restore/clear functions. |
| Previous Message | Richard Guo | 2025-11-11 06:58:31 | Use exact nullingrels matches for NestLoopParams |