| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, John Naylor <johncnaylorls(at)gmail(dot)com> |
| Subject: | Re: Reorganize GUC structs |
| Date: | 2025-11-07 15:14:55 |
| Message-ID: | 1227178.1762528495@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> Here are a few more small patches to fix related things I found
> afterwards or in passing.
Looks sane, except that the comparator could do with an extra "const"
if there's enough room on the line:
+ const struct config_generic *ca = *(const struct config_generic *const *) a;
+ const struct config_generic *cb = *(const struct config_generic *const *) b;
Not essential, but casting const away even transiently looks ugly.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maksim.Melnikov | 2025-11-07 15:19:39 | Re: Incorrect checksum in control file with pg_rewind test |
| Previous Message | Andres Freund | 2025-11-07 15:10:19 | Re: LTO aggressively optimizing out function despite explicit calls in logical decoding |