Re: Subscription tests vs log_error_verbosity

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Subscription tests vs log_error_verbosity
Date: 2022-06-12 14:19:23
Message-ID: f2e5d665-5618-3e95-8a86-48038c74872d@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2022-06-11 Sa 14:52, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> I have just got to the bottom of why the new subscription tests
>> 027_nosuperuser.pl and 029_on_error.pl have been failing for me - it's
>> because my test setup has log_error_verbosity set to 'verbose'. Either
>> we should force log_error_verbosity to 'default' for these tests, or we
>> should make the regexes we're testing for more forgiving as in the attached.
> +1 for the second answer. I don't like forcing parameter settings
> that we don't absolutely have to --- it reduces our test coverage.
> (Admittedly, changing log_error_verbosity in particular is probably
> not giving up much coverage, but as a general principle it's bad.)
>
>

Yeah, Done that way.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2022-06-12 14:57:00 Re: connection failures on forked processes
Previous Message Andrew Dunstan 2022-06-12 14:14:35 Re: Improve TAP tests of pg_upgrade for cross-version tests