| From: | Tomas Vondra <tomas(at)vondra(dot)me> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: vectorized CRC on ARM64 |
| Date: | 2026-04-04 18:36:53 |
| Message-ID: | f153d5a4-a9be-4211-b0b2-7e99b56d68d5@vondra.me |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I happened to do some testing on rpi5 with a 32-bit user space, and when
building with this commit I get these warnings from clang:
config.status: linking src/makefiles/Makefile.linux to src/Makefile.port
pg_crc32c_armv8_choose.c:112:1: warning: unused function
'pg_pmull_available' [-Wunused-function]
112 | pg_pmull_available(void)
| ^~~~~~~~~~~~~~~~~~
1 warning generated.
pg_crc32c_armv8_choose.c:112:1: warning: unused function
'pg_pmull_available' [-Wunused-function]
112 | pg_pmull_available(void)
| ^~~~~~~~~~~~~~~~~~
1 warning generated.
pg_crc32c_armv8_choose.c:112:1: warning: unused function
'pg_pmull_available' [-Wunused-function]
112 | pg_pmull_available(void)
| ^~~~~~~~~~~~~~~~~~
1 warning generated.
I suppose the pg_pmull_available() needs to be if-defed with
USE_PMULL_CRC32C_WITH_RUNTIME_CHECK. That removes the warning for me, at
least.
regards
--
Tomas Vondra
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-04-04 18:42:19 | Re: pg_plan_advice |
| Previous Message | Andrey Borodin | 2026-04-04 18:18:33 | Re: PG 19 release notes and authors |